Skip to content

Conversation

ckhordiasma
Copy link

No description provided.

@openshift-ci openshift-ci bot requested review from andyatmiami and daniellutz July 22, 2025 15:28
Copy link

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
unknown `Object 'Kind' is missing in '

empty file to prevent merge conflicts

'` |

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause error message from Konflux to appear as comment on every PR from now on:

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
unknown `Object 'Kind' is missing in '

empty file to prevent merge conflicts

'` |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having such empty files causes

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
unknown `Object 'Kind' is missing in '

empty file to prevent merge conflicts

'` |

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request adds 34 empty YAML files to the .tekton/ directory. The purpose of these files is to act as placeholders to prevent future merge conflicts, which is a sensible approach for the described workflow.

🔍 General Feedback

  • The changes are straightforward and align with the pull request's title and description.
  • There are no issues with correctness, efficiency, maintainability, or security.
  • The approach of using placeholder files is a good preventative measure for potential integration problems.

Overall, this is a good administrative change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants